CLN use pd.Timestamp for single element in converter #49148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Oct 17, 2022
| @@ -152,7 +152,7 @@ def _to_ordinalf(tm: pydt.time) -> float: | |||
|
|
|||
| def time2num(d): | |||
| if isinstance(d, str): | |||
| parsed = tools.to_datetime(d) | |||
| parsed = Timestamp(d) | |||
There was a problem hiding this comment.
This probably changes error messages? If yes, should add a whatsnew
There was a problem hiding this comment.
i think this also makes the check/raise on the next two lines unnecesary
There was a problem hiding this comment.
yeah good call, looks like they're uncovered as it is anyway https://app.codecov.io/gh/pandas-dev/pandas/blob/main/pandas/plotting/_matplotlib/converter.py
phofl
approved these changes
Oct 18, 2022
|
thx @MarcoGorelli |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only a single element is being parsed, and there's no way for a user to pass any options (like
dayfirst) throughax.set_xlim, so might as well usepd.Timestamp.Otherwise with #49024 users might get a warning they wouldn't be able to do anything about
Example of test that hits this:
pytest pandas/tests/plotting/test_datetimelike.py -k test_time_change_xlim